fix: inserted styles lost when moving elements #233
+357
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix code for nodejs tests change fix direction to avoid issues with duplicate styles format issues swap waitForTimeout for waitForRAF in test that flaked Add unit tests for new functions Fix broken test causes by file formatting removing spaced --------- Co-authored-by: jaj1014 <ajax@pendo.io> Co-authored-by: jaj1014 <jaj1014@users.noreply.github.com>
billyvg
changed the title
|
Applying rrweb-io#1357 to our fork |
chargome
approved these changes
Dec 18, 2024
| if (!elementCssRules || !elementCssRules.length) return; | ||
| // style sheet w/ innerText styles to diff with actual and get only inserted styles | ||
| const tempStyleSheet = new CSSStyleSheet(); | ||
| tempStyleSheet.replaceSync(styleElement.innerText); |
There was a problem hiding this comment.
This could be an issue for some safari users: https://caniuse.com/mdn-api_cssstylesheet_replacesync but I'd leave it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix code for nodejs tests
change fix direction to avoid issues with duplicate styles
format issues
swap waitForTimeout for waitForRAF in test that flaked
Add unit tests for new functions
Fix broken test causes by file formatting removing spaced
Co-authored-by: jaj1014 ajax@pendo.io
Co-authored-by: jaj1014 jaj1014@users.noreply.github.com